Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added note on private attrs and field func #6878

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Added note on private attrs and field func #6878

merged 2 commits into from
Jul 26, 2023

Conversation

RS-Credentive
Copy link
Contributor

Change Summary

Added a note to models.md under Private model attributes to clarify that field function cannot be used

Related issue number

fix #6877

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please review

RS-Credentive
RS-Credentive commented Jul 26, 2023
View reviewed changes
Copy link
Contributor Author

@RS-Credentive RS-Credentive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed trailing whitespace in markdown

@davidhewitt davidhewitt added the relnotes-ignore Omit this PR from the release notes. label Jul 26, 2023
davidhewitt
davidhewitt approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks helpful to me. Thanks!

@davidhewitt davidhewitt merged commit 37461ee into pydantic:main Jul 26, 2023
47 checks passed
@RS-Credentive RS-Credentive deleted the 6877-update-docs-no-field-function-private-attributes branch July 26, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Model page on docs.pydantic.com to clarify that field function cannot be used with private attributes.
2 participants
@RS-Credentive @davidhewitt