Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy issue with subclasses of RootModel #7677

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Fix mypy issue with subclasses of RootModel #7677

merged 5 commits into from
Sep 28, 2023

Commits on Sep 27, 2023

  1. first pass at fixing mypy argument error with subclasses of RootModel

    @sydney-runkle
    sydney-runkle committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    b6bbdcc View commit details
    Browse the repository at this point in the history

  2. restructuring fix + adding expected results for test

    @sydney-runkle
    sydney-runkle committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    2373c95 View commit details
    Browse the repository at this point in the history

  3. fix to remove call-arg error when extra field is included

    @sydney-runkle
    sydney-runkle committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    ad16bda View commit details
    Browse the repository at this point in the history

  4. Add test for extra fields error

    @dmontagu
    dmontagu committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    92ce4cb View commit details
    Browse the repository at this point in the history

  5. Fix error message

    @dmontagu
    dmontagu committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    fa02815 View commit details
    Browse the repository at this point in the history