Minor documentation updates requested in recent issues #7764

sydney-runkle · 2023-10-06T17:50:36Z

Change Summary

Update annotated import source for constrained types api doc (suggested in Error applying StringConstraint: StringConstraint() takes no argument #7747)
Update migration docs regarding Url behavioral changes (requested in AnyUrl adds trailing slash #7186 and AnyHttpUrl type appends a slash to the URL #6943).
Update migration docs regarding new/changed attribute copying behavior on model init (requested in Assigning mutable value to new field appears to make copy #7390)

The pull request title is a good summary of the changes - it will be used in the changelog
Unit tests for the changes exist
Tests pass on CI
Documentation reflects the changes where applicable
My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @Kludex

cloudflare-pages · 2023-10-06T17:51:33Z

Latest commit:	`7565d0d`
Status:	⚡️ Build in progress...

sydney-runkle · 2023-10-06T18:23:17Z

Please review

docs/migration.md

Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>

fixing annotated import for constrained types examples

0e9e72f

adding url change information

9ff5ed4

sydney-runkle added the relnotes-ignore Omit this PR from the release notes. label Oct 6, 2023

sydney-runkle added 2 commits October 6, 2023 13:12

remove unused example block

f6ba3d3

linting + adding attribute copy info to migration guide

0c9d207

sydney-runkle marked this pull request as ready for review October 6, 2023 18:21

pydantic-hooky bot added the ready for review label Oct 6, 2023

pydantic-hooky bot assigned Kludex Oct 6, 2023

sydney-runkle requested a review from Kludex October 6, 2023 18:58

Kludex approved these changes Oct 7, 2023

View reviewed changes

docs/migration.md Outdated Show resolved Hide resolved

Update docs/migration.md with only one suggestion for URL workaround.

7565d0d

Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>

sydney-runkle enabled auto-merge (squash) October 8, 2023 22:37

sydney-runkle merged commit 83d408f into main Oct 8, 2023
56 of 57 checks passed

sydney-runkle deleted the docs-updates-from-issues branch October 8, 2023 22:45