Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: emoji update to fix failing docs build #8334

Merged
merged 4 commits into from Dec 8, 2023
Merged

Conversation

sydney-runkle
Copy link
Member

@sydney-runkle sydney-runkle commented Dec 8, 2023

  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

See failing job: https://github.com/pydantic/pydantic/actions/runs/7130419364/job/19450666409?pr=8327

Selected Reviewer: @samuelcolvin

@sydney-runkle sydney-runkle added the relnotes-ignore Omit this PR from the release notes. label Dec 8, 2023
@sydney-runkle
Copy link
Member Author

Please review

Copy link

cloudflare-pages bot commented Dec 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9c1c4a0
Status: ✅  Deploy successful!
Preview URL: https://3976cd8b.pydantic-docs2.pages.dev
Branch Preview URL: https://emoji-docs-fix.pydantic-docs2.pages.dev

View logs

Copy link

codspeed-hq bot commented Dec 8, 2023

CodSpeed Performance Report

Merging #8334 will not alter performance

Comparing emoji-docs-fix (9c1c4a0) with main (d7ab7d6)

Summary

✅ 10 untouched benchmarks

@sydney-runkle sydney-runkle merged commit 9e2dcfe into main Dec 8, 2023
55 checks passed
@sydney-runkle sydney-runkle deleted the emoji-docs-fix branch December 8, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants