New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
really drop python<=3.7 support #9047
Conversation
CodSpeed Performance ReportMerging #9047 will not alter performanceComparing Summary
|
I believe the v1 code should be left as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, @Viicos is right! Let's leave the V1 code as is. Happy to review again once that's changed - thanks!
OK .. however I'm not sure about you are talking about so please close this PR and to it by yourself or merge than correct what still should be rolled back 😋 |
Basically the |
Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove the unused typing.Dict
and typing.Optional
imports? That should fix the pipeline for good!
In updated PR are only changes in tests/ and I see in that new diff any fiddling around imports 🤔 |
All good, I made the fixes. Thanks! |
OK now I see about what it was 😋 |
Yep, you can use |
Thank you because I had again opportunity to learned few small new details 👍 😄 |
Change Summary
Filter all code over
pyupgrade --py38
.Related issue number
N/A
Checklist