New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move enum
validation and serialization to Rust
#9064
Conversation
Deploying pydantic-docs with Cloudflare Pages
|
elif types == {bool}: | ||
result['type'] = 'boolean' | ||
elif types == {list}: | ||
result['type'] = 'array' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably need a test to check that tuple values generate the right schema.
CodSpeed Performance ReportMerging #9064 will improve performances by 30.01%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few thoughts! Looks good overall! Excited for the significant speedup :)
The only failing fastapi test is due to a Perhaps we could just open a heads up with a test fix on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking solid! We've done a clear win for the JSON north star. The Python north start is less signficant than I hoped; I'll have to dig around with that another time and see if there's any possible wins...
Update, the issue is with the |
0bf0172
to
1f0c7ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Change Summary
Sequel to pydantic/pydantic-core#1235, should give a 4x+ speedup to enum validation.
This will fail until we make a new pydantic-core release.
Checklist