New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default value serializing #9066
Fix default value serializing #9066
Conversation
CodSpeed Performance ReportMerging #9066 will not alter performanceComparing Summary
|
Please review |
This reverts commit 93d7dfd.
Something about this feels a bit fishy to me, but I suppose it's a pretty internal detail, so if we want to change this moving forward, we can. Going to go ahead and merge given that @davidhewitt approved. Thanks for your review DH, and thanks @NeevCohen for the great work on this! |
I guess we're only doing this for the json schema generation, so it is relatively low stakes. |
Great work you've been doing! Ping me if you need any direction or advice for other issues / feature requests, if you're interested! |
@sydney-runkle |
For what it's worth that was what I was thinking too. It's probably not exactly right, but it's likely better than what |
Change Summary
Fixing a bug where default values of model fields won't be serialized into the json schema
Related issue number
Fix #8942
Checklist
Selected Reviewer: @alexmojaki