Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded check for CoreSchema or CoreSchemaField in handler_func in GenerateJsonSchema.generate_inner #9454

Closed

Conversation

candleindark
Copy link
Contributor

@candleindark candleindark commented May 20, 2024

Change Summary

This PR removes the check for CoreSchema or CoreSchemaField in handler_func in GenerateJsonSchema.generate_inner. The check is always true.

This PR is not what is needed if the code before the change in this PR doesn't implement what is intended.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

The boolean expression in the if-statement is always true
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label May 20, 2024
Copy link

codspeed-hq bot commented May 20, 2024

CodSpeed Performance Report

Merging #9454 will not alter performance

Comparing candleindark:remove-unneeded-check (aad4779) with main (15b82a9)

Summary

✅ 13 untouched benchmarks

@candleindark
Copy link
Contributor Author

Please review.

@candleindark candleindark marked this pull request as ready for review May 20, 2024 01:08
@sydney-runkle
Copy link
Member

Hmm,

Though removing this check doesn't break any tests, I'd like to keep this as a support mechanism for folks who are customizing the JSON schema generation process. Thanks for your contribution though - we'd love to have your help with other issues, if you're interested!

@candleindark candleindark deleted the remove-unneeded-check branch May 22, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants