Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Duration parsing #35

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Conversation

aminalaee
Copy link
Contributor

Fixes #34

@aminalaee aminalaee changed the title Fix Duration parsing avoid timezone Fix Duration parsing Jun 12, 2023
@lig
Copy link

lig commented Jun 13, 2023

@samuelcolvin this blocks #34 which we want for Pydantic V2 Beta 3 pydantic/pydantic#6096

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise idea looks good i think.

src/duration.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Merging #35 (6dbfe4a) into main (aa33bd2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   99.50%   99.51%   +0.01%     
==========================================
  Files           6        6              
  Lines         801      819      +18     
==========================================
+ Hits          797      815      +18     
  Misses          4        4              
Impacted Files Coverage Δ
src/datetime.rs 96.62% <ø> (ø)
src/duration.rs 100.00% <100.00%> (ø)
src/time.rs 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa33bd2...6dbfe4a. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 47f1b32 into pydantic:main Jun 19, 2023
5 checks passed
@samuelcolvin
Copy link
Member

thanks so much.

@aminalaee aminalaee deleted the fix-duration-parsing branch June 19, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong error parsing duration
4 participants