Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative TzOffset to_string handling #56

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

sydney-runkle
Copy link
Member

Fix pydantic/pydantic#8964

Our logic was a bit off in terms of converting negative timezone offsets -> the corresponding minute / second string representations.

@sydney-runkle
Copy link
Member Author

Please review

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Merging #56 (a250007) into main (ef53708) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   99.12%   99.12%   -0.01%     
==========================================
  Files           6        6              
  Lines         918      917       -1     
==========================================
- Hits          910      909       -1     
  Misses          8        8              
Files Coverage Δ
src/time.rs 97.80% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef53708...a250007. Read the comment docs.

src/time.rs Outdated Show resolved Hide resolved
Co-authored-by: David Hewitt <david@hewitt.tech>
@sydney-runkle sydney-runkle merged commit d621186 into main Mar 12, 2024
7 checks passed
@sydney-runkle sydney-runkle deleted the fix-tzoffset branch March 12, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datetime dumping to json flips sign of timezone
2 participants