Simple devel test server #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laliberte
force-pushed
the
enhancement/simple_server
branch
from
0ae798b
to
4a32849
Compare
|
I feel this most recent attempt at tackling issue #33 is the cleanest approach possible and will provide a much needed feature for some related projects. Where do you stand on this @jameshiebert ? Ideally, I would like to merge this PR and #94 by the end of next week. |
laliberte
force-pushed
the
enhancement/simple_server
branch
from
4a32849
to
506df30
Compare
laliberte
force-pushed
the
enhancement/simple_server
branch
from
1bb95da
to
021baf0
Compare
|
@jameshiebert should I go ahead and merge this one? |
|
Yeah, this seems pretty reasonable. The only thing that I'd say is that it's probably worth adding a section in the server docs (with a big caveat that says this is not for production use). I'll merge this and create a separate issue for the docs. |
This was referenced May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the development test server from PR #34. The goal here is dissociate the merging of the CSV handler from the introduction of a test server.