Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template bug breaking ManifestStaticFilesStorage. #169

Merged
merged 2 commits into from Apr 14, 2017
Merged

Fix template bug breaking ManifestStaticFilesStorage. #169

merged 2 commits into from Apr 14, 2017

Conversation

martey
Copy link
Contributor

@martey martey commented Apr 14, 2017

No description provided.

@martey
Hotfix for #168 (fcde24f).
f3e188c 
Make sure that we are using the "static" templatetag instead of
concatening bare filenames with `STATIC_URL`. This ensures that the
filenames for each static file are correct.
@martey
Change where STATICFILES_STORAGE is defined.
e97ffd4 
Move STATICFILES_STORAGE from production settings to base settings.
While ManifestStaticFilesStorage does not run when DEBUG = True, this
still makes it easier to override the static storage backend in local
development, and we should try to have as few settings defined in the
environment-specific settings files as possible.

Note that ManifestStaticFilesStorage does not work in tests, so we need
to explicitly disable it in Travis-CI's settings.
@martey martey merged commit e97ffd4 into master Apr 14, 2017
martey added a commit that referenced this pull request Apr 14, 2017
@martey
Merge #169 (fix ManifestStaticFilesStorage issue).
3ecbcd1
@martey martey deleted the fix-staticfiles branch April 20, 2017 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@martey