-
Notifications
You must be signed in to change notification settings - Fork 204
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Force
shell=True
for subprocess call for Linux systems
- Loading branch information
1 parent
e88d1a5
commit 34b5f92
Showing
1 changed file
with
9 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure
shell=True
is required here. I think the problem is that the string needs to be broken up into tokens, likecheck_call([sys.executable, "-c", script])
.It's probably not too harmful to leave as-is, but I think
shell=True
is considered slower and less secure.