Use distutils.version.LooseVersion to avoid issue #312

pydata · Aug 15, 2018 · 4f4bb49 · 4f4bb49
1 parent b8f0d8d
commit 4f4bb49
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/RELEASE_NOTES.rst b/RELEASE_NOTES.rst
@@ -7,6 +7,8 @@ Changes from 2.6.7 to 2.6.8
 
 - Add check to make sure that `f_locals` is not actually `f_globals` when we 
   do the `f_locals` clear to avoid the #310 memory leak issue.
+- Compare NumPy versions using `distutils.version.LooseVersion` to avoid issue
+  #312 when working with NumPy development versions.
 
 Changes from 2.6.6 to 2.6.7
 ---------------------------

diff --git a/numexpr/expressions.py b/numexpr/expressions.py
@@ -17,8 +17,8 @@
 import numpy
 # numpy's behavoir sometimes changes with versioning, especially in regard as 
 # to when ints are cast to floats.
-from distutils.version import StrictVersion
-_np_version_forbids_neg_powint = StrictVersion(numpy.__version__) >= StrictVersion('1.12.0b1')
+from distutils.version import LooseVersion
+_np_version_forbids_neg_powint = LooseVersion(numpy.__version__) >= LooseVersion('1.12.0b1')
 
 # Declare a double type that does not exist in Python space
 double = numpy.double