New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constant dupes #415

Merged

robbmcleod merged 4 commits into pydata:master from Kirill888:fix-constant-dupes

Jul 15, 2022

Contributor

Kirill888 commented Jul 11, 2022

This pull requested fixes issue with constant duplication (#414).

But there are also some other minor fixes:

Properly parse where_xxxx instructions in disassembler (do not drop 4-th argument)
Allow nan floating point constant construction
Allow np.float32(v) constants (do not promote those to double)

Note that one can only use those constants when building expression with python classes directly, parsing nan or float32 out of textual representation is not enabled by this PR.

Closes #414

Kirill888 added 4 commits

July 11, 2022 23:05


          Fixes in disassembler

ed4cafa

- display 4-th argument for 8 byte instructions `where_xxxx`
- correct signature extraction for ops with multiple _ in the name
  `ones_like_XX`


          Fix constants reporting

0466f23

While register allocation assigned same register to constants
containing the same value and type, getConstants were returning
all constants with duplicates.


          Allow nan constants

2d84868


          Support numpy.float32 constants

b6f931c

do not convert them to double precision

Member

robbmcleod commented Jul 15, 2022

Looks good, thanks for the contribution.

robbmcleod merged commit cd5cbfd into pydata:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment