Merge pull request #584 from pydata/dividend_test

BUG: Fix dividend adjustment
pydata · Oct 20, 2018 · 7949e60 · 7949e60
2 parents 2276f59 + 367a9e6
commit 7949e60
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/docs/source/whatsnew/v0.8.0.txt b/docs/source/whatsnew/v0.8.0.txt
@@ -0,0 +1,31 @@
+.. _whatsnew_080:
+
+v0.8.0 (TBD)
+---------------------------
+
+Highlights include:
+
+.. contents:: What's new in v0.8.0
+    :local:
+    :backlinks: none
+
+.. _whatsnew_080.enhancements:
+
+Enhancements
+~~~~~~~~~~~~
+
+
+.. _whatsnew_080.api_breaking:
+
+Backwards incompatible API changes
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+
+
+.. _whatsnew_080.bug_fixes:
+
+Bug Fixes
+~~~~~~~~~
+
+- Fix Yahoo! actions issue where dividends are adjusted twice as a result of a
+  change to the Yahoo! API. (:issue: `583`)
diff --git a/pandas_datareader/yahoo/daily.py b/pandas_datareader/yahoo/daily.py
@@ -181,11 +181,10 @@ def _read_one_data(self, url, params):
                 splits['Splits'] = 1.0 / splits['SplitRatio']
                 prices = prices.join(splits['Splits'], how='outer')
 
-                if 'DIVIDEND' in types and not self.adjust_dividends:
+                if 'DIVIDEND' in types and self.adjust_dividends:
                     # Adjust dividends to deal with splits
                     adj = prices['Splits'].sort_index(ascending=False).fillna(
                         1).cumprod()
-                    adj = 1.0 / adj
                     prices['Dividends'] = prices['Dividends'] * adj
 
         return prices