Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't convert string to float '1,006.73' #345

Closed
martinffx opened this issue Jun 3, 2017 · 5 comments
Closed

Can't convert string to float '1,006.73' #345

martinffx opened this issue Jun 3, 2017 · 5 comments

Comments

@martinffx
Copy link

Amazon is too dam valuable!

>>> import pandas_datareader.data as web
>>>
>>> q = web.get_quote_google(['AMZN', 'GOOG'])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/martinrichards/code/play/stock-scraper/venv/lib/python3.6/site-packages/pandas_datareader/data.py", line 56, in get_quote_google
    return GoogleQuotesReader(*args, **kwargs).read()
  File "/Users/martinrichards/code/play/stock-scraper/venv/lib/python3.6/site-packages/pandas_datareader/base.py", line 69, in read
    return self._read_one_data(self.url, self.params)
  File "/Users/martinrichards/code/play/stock-scraper/venv/lib/python3.6/site-packages/pandas_datareader/base.py", line 79, in _read_one_data
    return self._read_lines(out)
  File "/Users/martinrichards/code/play/stock-scraper/venv/lib/python3.6/site-packages/pandas_datareader/google/quotes.py", line 33, in _read_lines
    for x in result], columns=['change_pct',
  File "/Users/martinrichards/code/play/stock-scraper/venv/lib/python3.6/site-packages/pandas_datareader/google/quotes.py", line 33, in <listcomp>
    for x in result], columns=['change_pct',
ValueError: could not convert string to float: '1,006.73'

Should be a simple fix, I'll try my hand at it and submit a PR.

@martinffx
Copy link
Author

Lots of test failures:

Ran 80 tests in 158.580s

FAILED (errors=17, failures=2)

@femtotrader
Copy link
Contributor

femtotrader commented Jun 3, 2017

This issue should be fixed by #335

@martinffx
Copy link
Author

ahh, was about to submit that exact fix as a PR. Any reason it hasn't been merged? Has the author not update with the PEP8 comment?

@femtotrader
Copy link
Contributor

I can't merge PRs that don't pass all unit tests
and I'm quite busy this year to fix all tests

Pinging @jreback @davidastephens @gfyoung

@jreback
Copy link
Contributor

jreback commented Jul 2, 2017

closed by #335

@jreback jreback closed this as completed Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants