Feature/Issue 376 Update EnigmaReader Data Connector #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydrosquall
force-pushed
the
feature/Issue-376-update-enigma-connector
branch
from
e21897b
to
a034f31
Compare
hydrosquall
force-pushed
the
feature/Issue-376-update-enigma-connector
branch
from
a034f31
to
f79ef9f
Compare
|
@jreback , this is ready for review :) |
jreback
requested changes
Aug 6, 2017
| @@ -202,15 +202,18 @@ Available expiry dates can be accessed from the ``expiry_dates`` property. | |||
| Enigma | |||
| ====== | |||
|
|
|||
| Access datasets from `Enigma <https://app.enigma.io>`__, | |||
There was a problem hiding this comment.
add a note/warning that this changed in 0.6.0
There was a problem hiding this comment.
Updated on line 207
docs/source/remote_data.rst
Outdated
| the world's largest repository of structured public data. | ||
|
|
||
| Datasets are unique identified by the ``uuid4`` at the end of a dataset's web address. | ||
| For example, the following code downloads USDA Food Recall Data from https://public.enigma.com/datasets/292129b0-1275-44c8-a6a3-2a0881f24fe1. |
There was a problem hiding this comment.
your https won't render, do like: `USDA Food Recal Data <https:.......>`__
|
@jreback , changes are complete! Let me know if you need anything else tweaked |
|
@jreback Would you like to see other updates to this PR? Thanks |
|
@davidastephens - would it be OK to role this PR into the next release? |
|
Update: |
|
Thanks @hydrosquall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #376, and includes
EnigmaReaderdata.pylibrary.The exact sunsetting date of
app.enigma.iois not determined, but is coming soon.