Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GoogleQuotesReader #188

Merged
merged 1 commit into from Mar 10, 2016

Conversation

@gliptak
Copy link
Contributor

gliptak commented Mar 2, 2016

def test_get_quote_string(self):
df = web.get_quote_google('GOOG')
self.assertTrue(df.ix['GOOG']['last'] > 0.0)

This comment has been minimized.

Copy link
@sinhrks

sinhrks Mar 2, 2016

Member

Pls test index and columns are correct using tm.assert_index_equal also in test_get_quote_stringlist.

This comment has been minimized.

Copy link
@gliptak

gliptak Mar 2, 2016

Author Contributor

Done.

@femtotrader

This comment has been minimized.

Copy link
Contributor

femtotrader commented Mar 6, 2016

Thanks @gliptak but you might add some tests to ensure type of returned data.

  • time is probably a datetime.time
  • change_pct and last a float or a Decimal
@sinhrks

This comment has been minimized.

Copy link
Member

sinhrks commented Mar 6, 2016

No, dtypes will be float, float, datetime[ns]. #188 adds a similar dtype test.

Using Decimal is regarded as obejct internally, and it causes some numeric ops not work.

@gliptak

This comment has been minimized.

Copy link
Contributor Author

gliptak commented Mar 6, 2016

Thanks for the pointers. Please review update.

@gliptak

This comment has been minimized.

Copy link
Contributor Author

gliptak commented Mar 6, 2016

@gliptak

This comment has been minimized.

Copy link
Contributor Author

gliptak commented Mar 7, 2016

Some code gymnastics ...

@gliptak

This comment has been minimized.

Copy link
Contributor Author

gliptak commented Mar 9, 2016

Any other changes you would like? Thanks

@femtotrader

This comment has been minimized.

Copy link
Contributor

femtotrader commented Mar 9, 2016

Sounds good to me. And you @sinhrks ? Can you squash commits @gliptak ?

@gliptak

This comment has been minimized.

Copy link
Contributor Author

gliptak commented Mar 9, 2016

Squashed.

numpy/numpy#7390

femtotrader added a commit that referenced this pull request Mar 10, 2016
ENH: Refactor GoogleQuotesReader
@femtotrader femtotrader merged commit b83430d into pydata:master Mar 10, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@femtotrader

This comment has been minimized.

Copy link
Contributor

femtotrader commented Mar 10, 2016

Thanks @gliptak

@gliptak gliptak deleted the gliptak:googlequote1 branch Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.