Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bankofcanada #416

Closed
wants to merge 2 commits into from
Closed

Bankofcanada #416

wants to merge 2 commits into from

Conversation

dwrpayne
Copy link
Contributor

@dwrpayne dwrpayne commented Oct 31, 2017 •
edited

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@davidastephens
Copy link
Member

Thanks, can you please add some tests and rebase?

@dwrpayne
Copy link
Contributor Author

Done - rebased and squashed, along with a set of unit tests.

@bashtage
Copy link
Contributor

Can you rebase on master? It should pass and then this can be merged.

@bashtage bashtage added this to the 0.6.0 milestone Jan 11, 2018
@bashtage bashtage mentioned this pull request Jan 11, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dwrpayne @davidastephens @bashtage