Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of pandas.io.common.get_filepath_or_buffer #860

Merged
merged 1 commit into from Jul 1, 2021

Conversation

kpj
Copy link
Contributor

@kpj kpj commented May 1, 2021

It seems like pandas (I am using v1.2.1) renamed pandas.io.common.get_filepath_or_buffer to pandas.io.common._get_filepath_or_buffer and changed its signature.
This makes, e.g., code like this crash:

import pandas_datareader as pdr
pdr.data.DataReader('hlth_hlye', 'eurostat')

This PR makes pandas_datareader.compat.get_filepath_or_buffer use the new interface.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

Codecov Report

Merging #860 (d5903db) into master (90f155a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
+ Coverage   64.03%   64.05%   +0.01%     
==========================================
  Files          65       65              
  Lines        2906     2907       +1     
  Branches      311      311              
==========================================
+ Hits         1861     1862       +1     
  Misses        969      969              
  Partials       76       76              
Impacted Files Coverage Δ
pandas_datareader/compat/__init__.py 82.35% <100.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f155a...d5903db. Read the comment docs.

@bashtage bashtage merged commit 6f0149e into pydata:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants