Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: enabling subplots works unexpectedly #6951

Closed
wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Apr 24, 2014

Found 2 minor issues related to plotting with subplots=True.

  1. If DataFrame only has single column, plot raises TypeError. It is because _subplots returns Axes instance, not array.
  2. If kind=scatter or kind=hexbin is specified with subplots=True, additional blank axes is drawn.

@sinhrks
Copy link
Member Author

sinhrks commented Apr 26, 2014

I found 3rd minor issue and fixed:

  • Calling Series.plot with subplots=True raises AttributeError

@jreback jreback added this to the 0.14.0 milestone Apr 27, 2014
@jreback
Copy link
Contributor

jreback commented Apr 27, 2014

seems reasonable, @TomAugspurger can you validate?

@TomAugspurger
Copy link
Contributor

This is good. @sinhrks do you want this one merged before your #6656?

@sinhrks
Copy link
Member Author

sinhrks commented Apr 28, 2014

Yes, please. Later, I'll finish #6656.

@TomAugspurger
Copy link
Contributor

@jreback this is OK, just a conflict in release.rst

Can I merge this from the command line with

git checkout -b sinhrks-scattersp2 master
git pull git://github.com/sinhrks/pandas.git scattersp2

fixing the conflict in release.rst, rebasing onto master, checking out master and merging this PR in, and pushing to upstream/master? I shouldn't force push to master right?

@jreback
Copy link
Contributor

jreback commented Apr 29, 2014

correct, don't force push to master

exactly correct on your git-fu!

@TomAugspurger
Copy link
Contributor

OK thanks.

merged via 97c4a2e

Thank @sinhrks

@jorisvandenbossche
Copy link
Member

@TomAugspurger maybe add this to the dev wiki somewhere? (how to merge a PR this way)

@TomAugspurger
Copy link
Contributor

@jreback
Copy link
Contributor

jreback commented Apr 30, 2014

nice!

@sinhrks sinhrks deleted the scattersp2 branch April 30, 2014 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants