Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/CI: include api docs on travis #12002

Closed

Conversation

jorisvandenbossche
Copy link
Member

Continuation of #11069 (It seems I cannot reopen that PR because I already force pushed the branch ..)

Closes #3800

TODO:

  • remove printing of doc build log file in after_script

@jorisvandenbossche
Copy link
Member Author

Reason for reopening this, is that I noticed that sphinx 1.3 seemed to be improved in performance. And indeed, now the doc build on travis takes less than 20 minutes, while before it hit the maximum travis run time of 50 min.

@jorisvandenbossche
Copy link
Member Author

@jreback Can you have a look at this? Note that there is still one temp commit that should be removed, so the full diff is not fully correct (and I also need to rebase)

This is related to #12003 (@shoyer), but I think this is still relevant. Maybe not necessarily for building the dev docs (if we start using RTD for this), but you can always check the doc build log for PRs this way.

@@ -11,3 +11,7 @@ echo "inside $0"
sudo apt-get update $APT_ARGS # run apt-get update for all versions

true # never fail because bad things happened here

if [ x"$DOC_BUILD" == x"" ]; then
exit 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be exit 0 (otherwise its an error and will fail travis)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though maybe this was for testing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this was for testing

@jreback
Copy link
Contributor

jreback commented Jan 21, 2016

./make.py
sh: 1: jupyter: not found
Running Sphinx v1.3.3

do you need to add jupyter to the install?

@jorisvandenbossche
Copy link
Member Author

Rebased, removed the temporary commit, and added nbconvert as a dependency

@TomAugspurger
Copy link
Contributor

FYI, I saw nbsphinx the other day. I ran it on our style notebook and it seemed to work pretty well. There were a few CSS things that don't get picked up properly, but we can probably move to that soon.

@jreback
Copy link
Contributor

jreback commented Jan 23, 2016

@jorisvandenbossche this looks good.

only thing (and can do later), is maybe move this build up so its the first one after main builds (before slow ones).

@jreback
Copy link
Contributor

jreback commented Jan 23, 2016

merge when ready (try out merge-pr.py)

@jorisvandenbossche jorisvandenbossche added this to the 0.18.0 milestone Jan 24, 2016
@jreback
Copy link
Contributor

jreback commented Jan 25, 2016

@jorisvandenbossche

build on master: https://travis-ci.org/pydata/pandas/jobs/104512895

failed apparently

@jorisvandenbossche
Copy link
Member Author

Thanks for noticing. Probably due to the adding of nbconvert to requirements before I merged (what will maybe have given an incompatible nbconvert and ipython version, will need to investigate that further).
I actually already failed in the PR, but because it's one of the allowed failures, I didn't notice ...

#12138

jreback pushed a commit that referenced this pull request Jan 26, 2016
See #12002 (comment)
Doc builds are failing, testing if using the latest `ipython` version
solves it.

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>

Closes #12138 from jorisvandenbossche/travis-full-doc and squashes the following commits:

b646ddb [Joris Van den Bossche] CI: latest ipython version for doc build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants