Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh9084_get_schema_index_parameter #12973

Closed

Conversation

trbs
Copy link

@trbs trbs commented Apr 24, 2016

closes #9084

  • new parameters are added to the end of the definition to remain backwards compatible.
  • index defaults to False (not True as in to_sql) to remain backwards compatible.
  • added tests

@jreback jreback added Enhancement IO SQL to_sql, read_sql, read_sql_query labels Apr 24, 2016
@jreback
Copy link
Contributor

jreback commented May 20, 2016

@jorisvandenbossche status?

@jreback
Copy link
Contributor

jreback commented Sep 9, 2016

can you rebase / update?

…eter

* github.com:pydata/pandas: (554 commits)
  BUG: compat with Stata ver 111
  Fix: F999 dictionary key '2000q4' repeated with different values (pandas-dev#14198)
  BLD: Test for Python 3.5 with C locale
  BUG: DatetimeTZBlock can't assign values near dst boundary
  BUG: union_categorical with Series and cat idx
  BUG: fix str.contains for series containing only nan values
  BUG: Categorical constructor not idempotent with ext dtype
  TST: Make encoded sep check more locale sensitive (pandas-dev#14161)
  DOC: minor typo in 0.19.0 whatsnew file (pandas-dev#14185)
  BUG: fix tz-aware datetime convert to DatetimeIndex (GH 14088)
  BUG : bug in setting a slice of a Series with a np.timedelta64
  RLS: v0.19.0rc1
  DOC: clean-up 0.19.0 whatsnew file (pandas-dev#14176)
  DOC: cleanup build warnings (pandas-dev#14172)
  Add steps to run gbq integration testing to the contributing docs (pandas-dev#14144)
  ENH: concat and append now can handle unordered categories (pandas-dev#13767)
  DEPR: Deprecate pandas.core.datetools (pandas-dev#14105)
  API/DEPR: Remove +/- as setops for DatetimeIndex/PeriodIndex (GH9630) (pandas-dev#14164)
  Fix trivial typo in comment (pandas-dev#14174)
  API/DEPR: Remove +/- as setops for Index (GH8227) (pandas-dev#14127)
  ...
@codecov-io
Copy link

codecov-io commented Sep 14, 2016

Current coverage is 85.23% (diff: 100%)

Merging #12973 into master will decrease coverage by 0.01%

@@             master     #12973   diff @@
==========================================
  Files           140        140          
  Lines         50563      50568     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43103      43101     -2   
- Misses         7460       7467     +7   
  Partials          0          0          

Powered by Codecov. Last update 54ab5be...679a799

@jreback
Copy link
Contributor

jreback commented Nov 25, 2016

@jorisvandenbossche status of this?

@jreback
Copy link
Contributor

jreback commented Feb 1, 2017

closing as stale

@jreback jreback closed this Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: support index=True for SQL io.sql.get_schema
3 participants