Create more verbose error message for unicode strings as formulas #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,6 +57,9 @@ def _try_incr_builders(formula_like, data_iter_maker, eval_env, | |||
| data_iter_maker, | |||
| NA_action) | |||
| else: | |||
| # check if formula_like is another string type (which might be unsupported) | |||
| if isinstance(formula_like, string_types): | |||
| raise PatsyError("Unsupported string type for formula (e.g., unicode in Python 2.X).") | |||
There was a problem hiding this comment.
I think this is written in a little confusing way -- the only posible cases are:
- Python 2:
string_typesis equivalent to(str, unicode).stris handled above, so onlyunicodecan hit this point. - Python 3:
string_typesis equivalent tostr.stris handled above, so this point can't be reached.
There aren't any other string types floating around.
So I'd probably write the check like if not six.PY3 and isinstance(formula_like, unicode): ..., and then the error message could be more specific. (Unfortunately you can't use if six.PY2 ... because apparently older versions of six define PY3 but not PY2... I got another bug report about this at some point.)
|
Also, could you add a test for this? We try to maintain ~100% line coverage. Just something simple like |
has2k1
added a commit
to has2k1/patsy
that referenced
this pull request
Oct 18, 2015
Closed
|
Closing in favor of #76. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of supporting unicode, give a useful error message when a formula is unicode.