Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize HTML structure and configuration of each of our major areas #1182

Closed
choldgraf opened this issue Feb 15, 2023 · 0 comments · Fixed by #1184
Closed

Standardize HTML structure and configuration of each of our major areas #1182

choldgraf opened this issue Feb 15, 2023 · 0 comments · Fixed by #1184
Milestone

Comments

@choldgraf
Copy link
Collaborator

I just realized that we still have some inconsistencies in how the major areas of our theme are structured. Not big ones, but if we're changing up our HTML structure anyway we might as well solve this now. I think that we basically want this to be the structure everywhere:

  • An if statement that only inserts the __inner container if there are components present (e.g. in navbar_start).
  • A starting container that has sub-sections for start and end
  • Something like for component in section_start: add component
  • A start and an end sub-section for each major area, corresponding to right and left sides of screen.

I think it shouldn't be too hard to quickly standardize this. I can try to do this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant