set html_tag block is missing data-content_root (sphinx 7.2+ basic theme change)

[kay-kim]

Sphinx basic theme seems to now use data-content_root instead of DOCUMENTATION_OPTIONS.URL_ROOT which is set in the html element.
See sphinx-doc/sphinx@8e730ae for the change.

As such, the sphinx 7.2+ search results for dirhtml builds have resulting urls that have search/undefined in them (which makes them 404 when a user clicks on the resulting links.

Maybe modifying https://github.com/pydata/pydata-sphinx-theme/blob/185a37aa36820f77bffa4c87a772092e9e7cc380/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html#L4C1-L6C13 to include data-content_root="../" might fix it?

[12rambau]

Do you have an example of such a behavior in our own doc (now finally building with Sphinx 7)? I fail to clearly understand what search result you are talking about and I want to make sure that such a modification is not going to impact older version of Sphinx (that we need to continue supporting).

[kay-kim]

So, I have an example on a locally built pydata-sphinx-theme docs (I pointed to where the link url has search/undefined -- all the results have that search/undefined in their urls)

As mentioned, this behavior happens for for dirhtml builds, so I did update noxfile.py to build dirhtml instead of html

[vkbo]

I'm encountering this issue as well. See: https://novelwriter.io/search.html?q=tags#

Here's the console log:

Edit: I downgraded Sphinx to 6.2.1 for now on my website, so it no longer produces this error.