Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darken scroll bars in dark mode #1505

Closed
leifwalsh opened this issue Oct 10, 2023 · 0 comments · Fixed by #1536
Closed

Darken scroll bars in dark mode #1505

leifwalsh opened this issue Oct 10, 2023 · 0 comments · Fixed by #1536
Labels
good first issue Good for newcomers kind: enhancement New feature or request tag: CSS CSS and SCSS related issues tag: javascript Pull requests that update Javascript code

Comments

@leifwalsh
Copy link
Contributor

In #1337 the custom scroll bars were removed for accessibility, but now they look starkly bright again in dark mode, and really cut the primary navbar away from the main content.

https://stackoverflow.com/a/66097469 shows a happy medium: setting color-scheme: dark when the dark theme is selected will fix the scroll bar coloring (and presumably other browser-default things, like unstyled input elements maybe).

I don't know scss enough to propose a diff but hopefully this is easy for someone?

@12rambau 12rambau added kind: enhancement New feature or request tag: CSS CSS and SCSS related issues tag: javascript Pull requests that update Javascript code good first issue Good for newcomers labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind: enhancement New feature or request tag: CSS CSS and SCSS related issues tag: javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants