Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to theme.toml once our minimum sphinx is at least 7.3 #1776

Open
lucyleeow opened this issue Apr 19, 2024 · 3 comments
Open

Move to theme.toml once our minimum sphinx is at least 7.3 #1776

lucyleeow opened this issue Apr 19, 2024 · 3 comments
Labels
kind: maintenance Improving maintainability and reducing technical debt

Comments

@lucyleeow
Copy link

lucyleeow commented Apr 19, 2024 •
edited

New Sphinx 7.3 now prefers theme.toml over theme.conf: sphinx-doc/sphinx#12265

Just a note to maybe consider changing.

(I noticed while debugging sphinx-doc/sphinx#12299)
@AA-Turner
Copy link
Contributor

Do note, theme.toml was only introduced in 7.3 -- the current Sphinx minimum version in PDT is 5.0.

A

@lucyleeow
Copy link
Author

Ah good point.

@drammock drammock changed the title Move to theme.toml Move to theme.toml once our minimum sphinx is at least 7.3 Apr 19, 2024
@drammock drammock added the kind: maintenance Improving maintainability and reducing technical debt label Apr 19, 2024
@drammock
Copy link
Collaborator

reopening as a TODO for the future

@drammock drammock reopened this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: maintenance Improving maintainability and reducing technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drammock @AA-Turner @lucyleeow