New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong shape of matmul result when the first input is 2-D #217

Merged
merged 3 commits into from Dec 11, 2018

Conversation

Projects
None yet
2 participants
@gongliyu
Copy link
Contributor

gongliyu commented Dec 11, 2018

When the first input is 2-D, #204 does not give the correct shape. This PR will Fix #202 in this case.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #217 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   97.58%   97.59%   +<.01%     
==========================================
  Files          11       11              
  Lines        1534     1539       +5     
==========================================
+ Hits         1497     1502       +5     
  Misses         37       37
Impacted Files Coverage Δ
sparse/coo/common.py 98.11% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de981ea...5cc73cc. Read the comment docs.

@hameerabbasi

This comment has been minimized.

Copy link
Collaborator

hameerabbasi commented Dec 11, 2018

Thanks, @gongliyu! Merging.

@hameerabbasi hameerabbasi merged commit 2f72c5c into pydata:master Dec 11, 2018

5 checks passed

LGTM analysis: Python No alert changes
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.58%)
Details
codecov/project 97.59% (+<.01%) compared to de981ea
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment