New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fancy indexing support for DOK item assignment #435
Conversation
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 95.37% 95.46% +0.09%
==========================================
Files 19 20 +1
Lines 2809 2846 +37
==========================================
+ Hits 2679 2717 +38
+ Misses 130 129 -1 |
It would be nice to get the code coverage up -- Look into |
Hi @hameerabbasi I've added a few more tests and it looks like it's hitting 100% of the diff. Please let me know if there's anything else you'd like to see! |
This should be the last change needed -- Sorry for the slow feedback loop. |
Co-authored-by: Hameer Abbasi <einstein.edison@gmail.com>
Not slow at all! Thank you for the prompt reviews 😃 |
Thanks @DragaDoncila! This is in! |
Modify
__setitem__
to support a subset of advanced/fancy indexing where all dimensions are indexed. This uses @stschroe's gist here.We also need
__getitem__
, but we thought we'd submit that as a separate PR.