Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Array API support - Part 1 #612

Merged
merged 1 commit into from Dec 21, 2023

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Dec 21, 2023

Hi @hameerabbasi,

This PR adds some improvements for Array API support: new functions and additional imports from the NumPy in the main namespace.

@mtsokol mtsokol self-assigned this Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Merging #612 (1d6943c) into master (0e283ff) will increase coverage by 0.51%.
The diff coverage is 83.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   90.99%   91.50%   +0.51%     
==========================================
  Files          20       20              
  Lines        3376     3497     +121     
==========================================
+ Hits         3072     3200     +128     
+ Misses        304      297       -7     

sparse/_coo/common.py Fixed Show fixed Hide fixed
import warnings

import numpy as np
import numba

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note

Module 'numba' is imported with both 'import' and 'import from'.

import numpy as np
import numba
import scipy.sparse

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note

Module 'scipy.sparse' is imported with both 'import' and 'import from'.
sparse/_compressed/indexing.py Fixed Show fixed Hide fixed
Comment on lines +2114 to +2116
def asarray(
obj, /, *, dtype=None, format="coo", backend="pydata", device=None, copy=False
):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
sparse/_common.py Fixed Show fixed Hide fixed
sparse/_coo/__init__.py Fixed Show fixed Hide fixed
sparse/_coo/__init__.py Fixed Show fixed Hide fixed
@hameerabbasi hameerabbasi merged commit 01d8934 into pydata:master Dec 21, 2023
12 of 13 checks passed
@hameerabbasi
Copy link
Collaborator

Thanks, @mtsokol!

@mtsokol mtsokol deleted the array-api-support branch December 22, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants