Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable benchmarks #651

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Enable benchmarks #651

merged 1 commit into from
Mar 21, 2024

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Mar 21, 2024

No description provided.

@mtsokol mtsokol force-pushed the enable-benchmarks branch 2 times, most recently from 7024c14 to 6ffac80 Compare March 21, 2024 12:09
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions. Did you get it working?

asv.conf.json Outdated Show resolved Hide resolved
asv.conf.json Show resolved Hide resolved
Copy link

github-actions bot commented Mar 21, 2024

Test Results

5 900 tests  ±0   5 869 ✅ +2   5m 31s ⏱️ - 1m 59s
    1 suites ±0      31 💤  - 2 
    1 files   ±0       0 ❌ ±0 

Results for commit 62cc15b. ± Comparison against base commit 440cb13.

This pull request skips 2 and un-skips 4 tests.
sparse.pydata_backend.tests.test_compressed ‑ test_reductions_float16[i8-None-sum-kwargs0]
sparse.pydata_backend.tests.test_coo ‑ test_reductions_float16[i8-axis4-mean-kwargs1]
sparse.pydata_backend.tests.test_compressed ‑ test_reductions_float16[i4-None-mean-kwargs1]
sparse.pydata_backend.tests.test_compressed ‑ test_reductions_float16[i4-None-sum-kwargs0]
sparse.pydata_backend.tests.test_coo ‑ test_reductions_float16[f8-None-sum-kwargs0]
sparse.pydata_backend.tests.test_coo ‑ test_reductions_float16[i8-None-sum-kwargs0]

♻️ This comment has been updated with latest results.

@mtsokol
Copy link
Collaborator Author

mtsokol commented Mar 21, 2024

Did you get it working?

@hameerabbasi Yes! Here are results: https://github.com/pydata/sparse/actions/runs/8374665448/job/22930405042?pr=651#step:6:15

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another suggestion to cut down on CI time as benchmarks expand.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@pydata pydata deleted a comment from github-actions bot Mar 21, 2024
@mtsokol mtsokol force-pushed the enable-benchmarks branch 2 times, most recently from 1d30990 to c4e5aef Compare March 21, 2024 14:30
hameerabbasi
hameerabbasi previously approved these changes Mar 21, 2024
asv.conf.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the excel work here, @mtsokol!

@hameerabbasi hameerabbasi enabled auto-merge (squash) March 21, 2024 14:35
@mtsokol mtsokol disabled auto-merge March 21, 2024 14:43
@mtsokol mtsokol enabled auto-merge March 21, 2024 14:43
@hameerabbasi hameerabbasi enabled auto-merge (squash) March 21, 2024 14:56
@hameerabbasi hameerabbasi merged commit fa89526 into main Mar 21, 2024
10 checks passed
@hameerabbasi hameerabbasi deleted the enable-benchmarks branch March 21, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants