Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Finch backend #657

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Update Finch backend #657

merged 2 commits into from
Mar 27, 2024

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Mar 26, 2024

Hi @hameerabbasi,

This small PR updates Finch backend with what we currently have in the latest finch-tensor release.

@mtsokol mtsokol self-assigned this Mar 26, 2024
Copy link

github-actions bot commented Mar 26, 2024

Test Results

5 899 tests  ±0   5 867 ✅ ±0   6m 10s ⏱️ +44s
    1 suites ±0      32 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit d93a6cf. ± Comparison against base commit c532a35.

This pull request skips 2 and un-skips 2 tests.
sparse.pydata_backend.tests.test_compressed ‑ test_reductions_float16[f4-None-sum-kwargs0]
sparse.pydata_backend.tests.test_coo ‑ test_reductions_float16[f4-None-sum-kwargs0]
sparse.pydata_backend.tests.test_coo ‑ test_reductions_float16[i4-None-sum-kwargs0]
sparse.pydata_backend.tests.test_coo ‑ test_reductions_float16[i8-None-sum-kwargs0]

♻️ This comment has been updated with latest results.

sparse/finch_backend/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mtsokol

@mtsokol mtsokol merged commit ee81cdc into main Mar 27, 2024
10 checks passed
@mtsokol mtsokol deleted the update-finch-backend branch March 27, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants