Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumPy 1.x CI. #705

Merged
merged 1 commit into from
Jun 20, 2024
Merged

NumPy 1.x CI. #705

merged 1 commit into from
Jun 20, 2024

Conversation

hameerabbasi
Copy link
Collaborator

No description provided.

@hameerabbasi hameerabbasi force-pushed the npy20-ci branch 6 times, most recently from ccc9cab to bf60894 Compare June 17, 2024 11:58
mtsokol
mtsokol previously approved these changes Jun 17, 2024
@hameerabbasi hameerabbasi enabled auto-merge (squash) June 17, 2024 12:27
@mtsokol
Copy link
Collaborator

mtsokol commented Jun 17, 2024

Hmm I think we have some issue with CI: array_api_tests (Finch) hangs on 95% for some reason (after rerunning it).

@hameerabbasi
Copy link
Collaborator Author

Yeah, I saw. 👀 Let me run it locally.

@hameerabbasi
Copy link
Collaborator Author

hameerabbasi commented Jun 18, 2024

Yeah, I saw. 👀 Let me run it locally.

Hmm, passes doesn't hang for me locally. I get the following failures though:

FAILED ../array-api-tests/meta_tests/test_pytest_helpers.py::test_assert_array_elements - AttributeError: 'float' object has no attribute '_elemwise_op'
FAILED ../array-api-tests/meta_tests/test_array_helpers.py::test_notequal - AssertionError: logical_not is not defined in sparse
FAILED ../array-api-tests/meta_tests/test_utils.py::test_int_to_dtype - juliacall.JuliaError: InexactError: trunc(UInt8, -1)
FAILED ../array-api-tests/meta_tests/test_hypothesis_helpers.py::test_symmetric_matrices - AttributeError: 'Tensor' object has no attribute 'mT'
FAILED ../array-api-tests/meta_tests/test_hypothesis_helpers.py::test_positive_definite_matrices - AssertionError: broadcast_to is not defined in sparse

@hameerabbasi
Copy link
Collaborator Author

Yeah, I saw. 👀 Let me run it locally.

Hmm, passes doesn't hang for me locally. I get the following failures though:

FAILED ../array-api-tests/meta_tests/test_pytest_helpers.py::test_assert_array_elements - AttributeError: 'float' object has no attribute '_elemwise_op'
FAILED ../array-api-tests/meta_tests/test_array_helpers.py::test_notequal - AssertionError: logical_not is not defined in sparse
FAILED ../array-api-tests/meta_tests/test_utils.py::test_int_to_dtype - juliacall.JuliaError: InexactError: trunc(UInt8, -1)
FAILED ../array-api-tests/meta_tests/test_hypothesis_helpers.py::test_symmetric_matrices - AttributeError: 'Tensor' object has no attribute 'mT'
FAILED ../array-api-tests/meta_tests/test_hypothesis_helpers.py::test_positive_definite_matrices - AssertionError: broadcast_to is not defined in sparse

Same for Docker:

FROM --platform=amd64 python:3.10
RUN apt install git
WORKDIR /root
RUN git clone --depth 1 https://github.com/pydata/sparse.git
RUN git clone https://github.com/data-apis/array-api-tests.git
WORKDIR /root/array-api-tests
RUN git checkout 33f2d2ea2f3dd2b3ceeeb4519d55e08096184149
RUN git submodule update --init
WORKDIR /root/sparse
RUN pip install ".[all]"
RUN pip install -r "../array-api-tests/requirements.txt"
RUN python -c "import finch"
ENTRYPOINT ARRAY_API_TESTS_MODULE=sparse SPARSE_BACKEND=Finch pytest ../array-api-tests -v -c ../array-api-tests/pytest.ini --max-examples=2 --derandomize --disable-deadline -o xfail_strict=True --xfails-file ../sparse/ci/Finch-array-api-xfails.txt --skips-file ../sparse/ci/Finch-array-api-skips.txt --disable-warnings -n 4

@hameerabbasi hameerabbasi merged commit de312ea into pydata:main Jun 20, 2024
14 of 15 checks passed
@hameerabbasi hameerabbasi deleted the npy20-ci branch June 20, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants