You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #125 I went the route of forcing datetimes to be datetime64[ns]. This is probably part of a broader conversation, but doing so might save some future headaches. Of course ... it would also restrict us to nanosecond precision. Basically I feel like we should either force datetimes to be datetime64[ns] or make sure that operations on datetime objects preserve their type.
Probably worth getting this in and picking that conversation back up if needed. In which case could you add tests which make sure variables with datetime objects are still datetime objects after concatenation? If those start getting cast to datetime[ns] it'll start get confusing for users.
Also worth considering: how should datetime64[us] datetimes be handled? Currently they get cast to [ns] which, since datetimes do not, could get confusing.
The text was updated successfully, but these errors were encountered:
Todo:
Currently:
np.datetime64
arrays or objects are converted to ns precisionArguably, we should convert everything to
'datetime64[ns]'
, if possible. This is the approach we now take for decoding NetCDF time variables (#126).Reference discussion: #134. From @akleeman:
The text was updated successfully, but these errors were encountered: