-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO: xray objects support the pickle protocol #24
Comments
|
Something to consider is whether we should always store the data as an ndarray before pickling an XArray, or whether we should just store a reference to the original sources (e.g., make a pickle-able version of netCDF4.Variable). I am inclined to the former so pickle can be used a simple serialization format, but Iris has implemented the later approach. |
Some investigation reveals that this is only an issue when pickling datasets containing netCDF4.Variable objects (not xray.Variable objects). So the simple fix should be to make sure that all values are loaded into memory before pickling an xray.Variable. |
* added methods from xarray.core._typed_ops.py to list to map over * test ops with non-datatrees acting on datatrees * removed the xfails * refactored ops out into new file * linting * minimise imports of xarray internals
I actually don't know if our current objects support pickle. But we should add tests and make sure this works, for a dead simple form of inter-process communication.
The text was updated successfully, but these errors were encountered: