Unify netCDF4 and scipy backends in the public API #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GH273 To serialize a dataset to a string/bytes, simply use `ds.to_netcdf()`. This behavior copies `DataFrame.to_csv()` from pandas. This change also adds support for writing datasets to a particular NETCDF4 group. The legacy `dump` and `dumps` methods are deprecated.
shoyer
force-pushed
the
to_netcdf-refresh
branch
from
d4c1b09
to
e5f8a0e
Compare
shoyer
force-pushed
the
to_netcdf-refresh
branch
from
d4d22f1
to
fc5d2e9
Compare
shoyer
changed the title
| @@ -54,7 +54,7 @@ def _nc4_values_and_dtype(var): | |||
| return var, dtype | |||
|
|
|||
|
|
|||
| def _nc4_group(ds, group): | |||
| def _nc4_group(ds, group, mode): | |||
There was a problem hiding this comment.
It'd be nice to have a way to list groups in a netCDF, to facilitate opening ... but that's probably future work.
There was a problem hiding this comment.
At some point, it could be nice to have a full API for loading a set of datasets from groups. But not in this PR.
shoyer
added a commit
that referenced
this pull request
Feb 25, 2015
Unify netCDF4 and scipy backends in the public API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #273
and half of #272
To serialize a dataset to a string/bytes, simply use
ds.to_netcdf(). This behavior copiesDataFrame.to_csv()from pandas. The legacydumpanddumpsmethods are deprecated.My main concern is that the default "format" option is depends on what dependencies the user has installed or if they are saving a file. That seems non-ideal, but may perhaps be the most pragmatic choice given the limitations of the netCDF4 format.
This change also adds:
CC @akleeman