Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.15.0? #3702

Closed
7 of 11 tasks
dcherian opened this issue Jan 17, 2020 · 17 comments
Closed
7 of 11 tasks

release 0.15.0? #3702

dcherian opened this issue Jan 17, 2020 · 17 comments

Comments

@dcherian
Copy link
Contributor

dcherian commented Jan 17, 2020

It's been 2 months since our last release. It'd be nice to issue one soon; mostly to get the really nice documentation changes out.

According to our min versions policy we can bump up to numpy 1.15 and dask 2.2 (though we need to solve #3660 first). So I propose we do that and bump to 0.15.0

must-have:

close/ready and nice to have:

@keewis
Copy link
Collaborator

keewis commented Jan 17, 2020

I'd say all of the PRs related to #3594 (making all non-indexing tests pass and documentation) should be put into the same release. There is not too much to do so if I get about a week I can make sure all of them are ready for review / merge, but I'm also fine with not including them in 0.15

@dcherian
Copy link
Contributor Author

Should be ready to go once #3631 is in.

@dcherian
Copy link
Contributor Author

Do we have volunteers to do this release?

@dcherian
Copy link
Contributor Author

dcherian commented Jan 30, 2020

I am doing this (EDIT): in the next two hours unless there are objections.

@keewis
Copy link
Collaborator

keewis commented Jan 30, 2020

no objections from me

@dcherian
Copy link
Contributor Author

git clean -xdf; python setup.py bdist_wheel sdist; twine check dist/*

gives me

  `long_description` has syntax errors in markup and would not be rendered on PyPI.
    line 39: Warning: Bullet list ends without a blank line; unexpected unindent.

Can someone figure what needs to be fixed please?

@rabernat
Copy link
Contributor

Thanks @dcherian for handling this release!

I believe this is the problem. (line 39 of the description is like 47 of the file)

xarray/setup.cfg

Lines 46 to 47 in 7c32c8a

- Select values by label instead of integer location:
``x.loc['2014-01-01']`` or ``x.sel(time='2014-01-01')``.

I guess we are not continuing the line properly.

@keewis
Copy link
Collaborator

keewis commented Jan 30, 2020

the reason for this is that we have bullet lists with more than one line per item. python setup.py sdist (and others) will reindent the lines not preceded by the bullet (-) to match the indent of the bullet.

Is there a reason why we put a string there instead of using something like file: README.rst?

@dcherian
Copy link
Contributor Author

will reindent the lines not preceded by the bullet (-) to match the indent of the bullet.

That was it!

Is there a reason why we put a string there instead of using something like file: README.rst?

No idea. let's tackle this after this release.

@keewis
Copy link
Collaborator

keewis commented Jan 30, 2020

did you tag already? If not, I think it might be good to get #3732 in.

@dcherian
Copy link
Contributor Author

OK everything but the email, twitter announcements is done. I'll get to that tonight/tomorrow

@dcherian
Copy link
Contributor Author

great RTD is now failing consistently: https://readthedocs.org/projects/xray/builds/

@keewis
Copy link
Collaborator

keewis commented Jan 30, 2020

that's because conda uses too much memory. We might be able to reduce the memory consumption by moving most packages into the pip section (except from iris and cartopy every package should have wheels PyPI)

@max-sixty
Copy link
Collaborator

Thanks @dcherian !

And @keewis for being so helpful recently!

@dcherian
Copy link
Contributor Author

Update: RTD is fixed but the conda-forge channel needs some attention: conda-forge/xarray-feedstock#54

@crusaderky
Copy link
Contributor

    ERROR: Could not find a version that satisfies the requirement setuptools_scm (from versions: none)
    ERROR: No matching distribution found for setuptools_scm

Should get fixed by changing recipe/meta.yaml:

requirements:
  build:
    - python >=3.6
    - pip
    - setuptools
    - setuptools_scm

@dcherian
Copy link
Contributor Author

dcherian commented Feb 3, 2020

Done!

@dcherian dcherian closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants