Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing type checking CI #4225

Closed
keewis opened this issue Jul 15, 2020 · 2 comments
Closed

failing type checking CI #4225

keewis opened this issue Jul 15, 2020 · 2 comments

Comments

@keewis
Copy link
Collaborator

keewis commented Jul 15, 2020

Due to the update of pytest, mypy reports errors:

xarray/tests/test_cftimeindex_resample.py:57: error: List or tuple expected as variable arguments
xarray/tests/test_dataset.py:2407: error: No overload variant of "__call__" of "_XfailMarkDecorator" matches argument type "Type[AssertionError]"
xarray/tests/test_dataset.py:2407: note: Possible overload variant:
xarray/tests/test_dataset.py:2407: note:     def __call__(self, condition: Union[str, bool] = ..., *conditions: Union[str, bool], reason: str = ..., run: bool = ..., raises: Union[BaseException, Tuple[BaseException, ...]] = ..., strict: bool = ...) -> MarkDecorator
xarray/tests/test_dataset.py:2407: note:     <1 more non-matching overload not shown>
xarray/tests/test_dask.py:767: error: No overload variant of "__call__" of "_XfailMarkDecorator" matches argument type "Type[NotImplementedError]"
xarray/tests/test_dask.py:767: note: Possible overload variant:
xarray/tests/test_dask.py:767: note:     def __call__(self, condition: Union[str, bool] = ..., *conditions: Union[str, bool], reason: str = ..., run: bool = ..., raises: Union[BaseException, Tuple[BaseException, ...]] = ..., strict: bool = ...) -> MarkDecorator
xarray/tests/test_dask.py:767: note:     <1 more non-matching overload not shown>
xarray/tests/test_dataarray.py:3953: error: No overload variant of "__call__" of "_XfailMarkDecorator" matches argument type "Type[AssertionError]"
xarray/tests/test_dataarray.py:3953: note: Possible overload variant:
xarray/tests/test_dataarray.py:3953: note:     def __call__(self, condition: Union[str, bool] = ..., *conditions: Union[str, bool], reason: str = ..., run: bool = ..., raises: Union[BaseException, Tuple[BaseException, ...]] = ..., strict: bool = ...) -> MarkDecorator
xarray/tests/test_dataarray.py:3953: note:     <1 more non-matching overload not shown>
Found 4 errors in 4 files (checked 124 source files)

since that particular pytest version is a release candidate, should we pin pytest for now?

@keewis
Copy link
Collaborator Author

keewis commented Jul 15, 2020

both types of errors are fixed on pytest master so it should be possible to pin pytest and remove the pin once 6.0.0 was released.

@keewis keewis mentioned this issue Jul 15, 2020
1 task
@keewis
Copy link
Collaborator Author

keewis commented Jul 15, 2020

this seems to have been a mistake in the conda feedstock

@keewis keewis closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant