Retain label type in .to_dataset #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
changed the title
max-sixty
changed the title
|
@shoyer - I don't remember which issue it was but I seem to remember implementing this on purpose. I think we were having trouble serializing and round-tripping with non string type labels. Ring a bell? |
|
I recall discussing this and coming to the conclusion that any hashable object should be valid as dataset keys. Obviously, you need strings if you want to use standard serialization backends, but otherwise it's better to keep things flexible. |
|
@MaximilianR could please add a quick what's new note? otherwise this looks good to me |
|
@shoyer Added What's New - cheers |
shoyer
added a commit
that referenced
this pull request
Feb 14, 2016
Retain label type in .to_dataset
flamingbear
added a commit
to flamingbear/xarray
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this was a deliberate choice (maybe so integer indexing wasn't disrupted?). This allows objects as dataset keys / labels.
Let me know your thoughts and I'll add a what's new.
(I know I have a few PRs dangling - apologies - will go back and clean them up soon)