Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pint errors on python 3.11 and windows #7971

Closed
Illviljan opened this issue Jul 10, 2023 · 2 comments · Fixed by #8445
Closed

Pint errors on python 3.11 and windows #7971

Illviljan opened this issue Jul 10, 2023 · 2 comments · Fixed by #8445
Labels
bug needs triage Issue that has not been reviewed by xarray team member

Comments

@Illviljan
Copy link
Contributor

Illviljan commented Jul 10, 2023

What happened?

The CI seems to consistently crash on test_units.py now:

=========================== short test summary info ===========================
FAILED xarray/tests/test_units.py::TestVariable::test_aggregation[int32-method_max] - TypeError: no implementation found for 'numpy.max' on types that implement __array_function__: [<class 'pint.util.Quantity'>]
FAILED xarray/tests/test_units.py::TestVariable::test_aggregation[int32-method_min] - TypeError: no implementation found for 'numpy.min' on types that implement __array_function__: [<class 'pint.util.Quantity'>]
FAILED xarray/tests/test_units.py::TestDataArray::test_aggregation[float64-function_max] - TypeError: no implementation found for 'numpy.max' on types that implement __array_function__: [<class 'pint.util.Quantity'>]
FAILED xarray/tests/test_units.py::TestDataArray::test_aggregation[float64-function_min] - TypeError: no implementation found for 'numpy.min' on types that implement __array_function__: [<class 'pint.util.Quantity'>]
FAILED xarray/tests/test_units.py::TestDataArray::test_aggregation[int32-function_max] - TypeError: no implementation found for 'numpy.max' on types that implement __array_function__: [<class 'pint.util.Quantity'>]
FAILED xarray/tests/test_units.py::TestDataArray::test_aggregation[int32-function_min] - TypeError: no implementation found for 'numpy.min' on types that implement __array_function__: [<class 'pint.util.Quantity'>]
FAILED xarray/tests/test_units.py::TestDataArray::test_aggregation[int32-method_max] - TypeError: no implementation found for 'numpy.max' on types that implement __array_function__: [<class 'pint.util.Quantity'>]
FAILED xarray/tests/test_units.py::TestDataArray::test_aggregation[int32-method_min] - TypeError: no implementation found for 'numpy.min' on types that implement __array_function__: [<class 'pint.util.Quantity'>]
FAILED xarray/tests/test_units.py::TestDataArray::test_unary_operations[float64-round] - TypeError: no implementation found for 'numpy.round' on types that implement __array_function__: [<class 'pint.util.Quantity'>]
FAILED xarray/tests/test_units.py::TestDataArray::test_unary_operations[int32-round] - TypeError: no implementation found for 'numpy.round' on types that implement __array_function__: [<class 'pint.util.Quantity'>]
FAILED xarray/tests/test_units.py::TestDataset::test_aggregation[int32-method_max] - TypeError: no implementation found for 'numpy.max' on types that implement __array_function__: [<class 'pint.util.Quantity'>]
FAILED xarray/tests/test_units.py::TestDataset::test_aggregation[int32-method_min] - TypeError: no implementation found for 'numpy.min' on types that implement __array_function__: [<class 'pint.util.Quantity'>]
= 12 failed, 14880 passed, 1649 skipped, 146 xfailed, 68 xpassed, 574 warnings in 737.19s (0:12:17) =

For more details:
https://github.com/pydata/xarray/actions/runs/5438369625/jobs/9889561685?pr=7955

@Illviljan Illviljan added bug needs triage Issue that has not been reviewed by xarray team member labels Jul 10, 2023
Illviljan added a commit that referenced this issue Jul 10, 2023
Should be undone whenever root cause is fixed, #7971.
@keewis keewis mentioned this issue Nov 12, 2023
2 tasks
@max-sixty
Copy link
Collaborator

max-sixty commented Feb 26, 2024

Is this still an issue? I'm guessing we can close given we have successful CI? Or tests are still excluded?

@max-sixty max-sixty reopened this Feb 26, 2024
@keewis keewis linked a pull request Feb 26, 2024 that will close this issue
2 tasks
@keewis
Copy link
Collaborator

keewis commented Feb 26, 2024

should have been closed by #8445.

@keewis keewis closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage Issue that has not been reviewed by xarray team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants