Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add py3.12 CI and update pyproject.toml #8580

Closed
dcherian opened this issue Jan 3, 2024 · 2 comments · Fixed by #8605
Closed

add py3.12 CI and update pyproject.toml #8580

dcherian opened this issue Jan 3, 2024 · 2 comments · Fixed by #8605
Labels
Automation Github bots, testing workflows, release automation

Comments

@dcherian
Copy link
Contributor

dcherian commented Jan 3, 2024

What is your issue?

We haven't done this yet!

xarray/pyproject.toml

Lines 11 to 15 in d87ba61

"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Topic :: Scientific/Engineering",

@dcherian dcherian added needs triage Issue that has not been reviewed by xarray team member Automation Github bots, testing workflows, release automation and removed needs triage Issue that has not been reviewed by xarray team member labels Jan 3, 2024
@jhamman
Copy link
Member

jhamman commented Jan 3, 2024

I think @keewis tried 3.12 back in Nov but it wasn't ready. #8416. Would be great to revisit.

@keewis
Copy link
Collaborator

keewis commented Jan 3, 2024

👍

Typically it's numba that takes a while, so we'd need to remove it (and sparse / numbagg) from the environment. For 3.11 I created a separate environment file (two files, all and windows), we could do the same for 3.12

@keewis keewis mentioned this issue Jan 12, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Automation Github bots, testing workflows, release automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

run CI on python=3.12 keewis/xarray
3 participants
@jhamman @dcherian @keewis