Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate the other CI to python 3.11 #8416

Merged
merged 7 commits into from Nov 17, 2023
Merged

migrate the other CI to python 3.11 #8416

merged 7 commits into from Nov 17, 2023

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Nov 5, 2023

(namely, additional CI and upstream-dev CI)

python=3.11 has been released more than a year ago and python=3.12 is out as well, which means that it is a good idea to migrate sooner than later.

Regarding python=3.12, usually it is numba that keeps us from testing on a new python version for some time, where numbagg and sparse are the only dependencies that would use it. Should we create a environment without those two dependencies and switch back to the normal one once numba supports the new python version?

We still have the special environment files for python>=3.11 because the normal ones still include cdms2. We deprecated that back in May – not sure which release that ended up in – but since cdms2 will be abandoned end of this year, that's when we're free to drop support and merge both environments (though maybe we can justify dropping support earlier?)

@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Nov 5, 2023
@keewis keewis added run-upstream Run upstream CI and removed Automation Github bots, testing workflows, release automation labels Nov 5, 2023
@max-sixty
Copy link
Collaborator

Sounds great on all counts!

@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Nov 16, 2023
@max-sixty
Copy link
Collaborator

Shall we merge?

@keewis
Copy link
Collaborator Author

keewis commented Nov 16, 2023

before merging we probably need to silence the cgi deprecation warning raised by one of pydap's dependencies (pydap is imported in xarray.tests.__init__).

@keewis keewis added the plan to merge Final call for comments label Nov 16, 2023
@dcherian dcherian merged commit b6eaf43 into pydata:main Nov 17, 2023
28 of 32 checks passed
dcherian added a commit to rabernat/xarray that referenced this pull request Nov 29, 2023
* main:
  [skip-ci] dev whats-new (pydata#8467)
  2023.11.0 Whats-new (pydata#8461)
  migrate the other CI to python 3.11 (pydata#8416)
  preserve vlen string dtypes, allow vlen string fill_values (pydata#7869)
  Pin mypy < 1.7 (pydata#8458)
  Fix typos found by codespell (pydata#8457)
  [skip-ci] Small updates to IO docs. (pydata#8452)
  Deprecate certain cftime frequency strings following pandas (pydata#8415)
  Added driver parameter for h5netcdf (pydata#8360)
  Raise exception in to_dataset if resulting variable is also the name of a coordinate (pydata#8433)
  Automatic region detection and transpose for `to_zarr()` (pydata#8434)
  remove `cdms2` (pydata#8441)
  Remove PseudoNetCDF (pydata#8446)
  Pin pint to >=0.22 (pydata#8445)
  Remove keep_attrs from resample signature (pydata#8444)
  Rename `to_array` to `to_dataarray` (pydata#8438)
  Add missing DataArray.dt.total_seconds() method (pydata#8435)
  Declare Dataset, DataArray, Variable, GroupBy unhashable (pydata#8392)
@keewis keewis deleted the py311 branch January 3, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Github bots, testing workflows, release automation plan to merge Final call for comments run-upstream Run upstream CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants