Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix h5netcdf saving scalars with filters or chunks #2591

Merged
merged 4 commits into from
Dec 11, 2018
Merged

Fix h5netcdf saving scalars with filters or chunks #2591

merged 4 commits into from
Dec 11, 2018

Conversation

mraspaud
Copy link
Contributor

@mraspaud mraspaud commented Dec 5, 2018 •
edited
Loading

  • Closes Scalars from netcdf dataset can't be written with h5netcdf #2563
  • Tests added (for all bug fixes or enhancements)
  • Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

@pep8speaks
Copy link

Hello @mraspaud! Thanks for submitting the PR.

@mraspaud
Copy link
Contributor Author

mraspaud commented Dec 5, 2018

I'm not sure if I need to document anything as this is just a bugfix ?

@mraspaud
Copy link
Contributor Author

mraspaud commented Dec 6, 2018

Am I right in thinking the failing travis and appveyor build aren't my doing ?

@mraspaud
Copy link
Contributor Author

Ok travis seems to pass, how about appveyor ? There are many time encoding errors, should it be so ?

@spencerkclark
Copy link
Member

Ok travis seems to pass, how about appveyor ? There are many time encoding errors, should it be so ?

I believe those are unrelated to this PR. There was a series of bug fix releases of cftime following the initial 1.0.3 release (the failing build here uses 1.0.3). I think with the latest one (1.0.3.4), released a few days ago, things should be back to normal (as evidenced by the build passing in #2596).

@mraspaud
Copy link
Contributor Author

Ok good, I'll let this run it's course then.
How about whats-new.rst, do you want me to fill in something there?

@spencerkclark
Copy link
Member

How about whats-new.rst, do you want me to fill in something there?

Yes, I think it would make sense to document this change under the "Bug fixes" heading.

@shoyer shoyer merged commit 53746c9 into pydata:master Dec 11, 2018
@shoyer
Copy link
Member

shoyer commented Dec 11, 2018

thanks!

@mraspaud mraspaud deleted the fix-h5netcdf-scalars branch December 11, 2018 07:27
dcherian pushed a commit to yohai/xarray that referenced this pull request Dec 16, 2018
Merge remote-tracking branch 'upstream/master' into yohai-ds_scatter
6975b9e 
* upstream/master:
  Feature: N-dimensional auto_combine (pydata#2553)
  Support HighLevelGraphs (pydata#2603)
  Bump cftime version in doc environment (pydata#2604)
  use keep_attrs in binary operations II (pydata#2590)
  Temporarily mark dask-dev build as an allowed failure (pydata#2602)
  Fix wrong error message in interp() (pydata#2598)
  Add dayofyear and dayofweek accessors (pydata#2599)
  Fix h5netcdf saving scalars with filters or chunks (pydata#2591)
  Minor update to PR template (pydata#2596)
  Zarr consolidated (pydata#2559)
  fix examples (pydata#2581)
  Fix typo (pydata#2578)
  Concat docstring typo (pydata#2577)
  DOC: remove example using Dataset.T (pydata#2572)
  python setup.py test now works by default (pydata#2573)
  Return slices when possible from CFTimeIndex.get_loc() (pydata#2569)
  DOC: fix computation.rst (pydata#2567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scalars from netcdf dataset can't be written with h5netcdf
4 participants
@mraspaud @pep8speaks @spencerkclark @shoyer