BUG: fix + test open_mfdataset fails on variable attributes with list… #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type Using open_mfdataset on a series of netcdf files having variable attributes with type list will fail with the following exception, when these attributes have different values from one file to another: solves: pydata#3034
Codecov Report
@@ Coverage Diff @@
## master #3181 +/- ##
==========================================
- Coverage 95.7% 95.69% -0.01%
==========================================
Files 63 63
Lines 12839 12848 +9
==========================================
+ Hits 12287 12295 +8
- Misses 552 553 +1 |
max-sixty
approved these changes
Aug 3, 2019
There was a problem hiding this comment.
Thanks @HasanAhmadQ7 !
I added a small tweak; then ready to merge
xarray/core/utils.py
Outdated
| return False | ||
| else: | ||
| for i in range(len(first)): | ||
| equiv = equiv and equivalent(first[i], second[i]) |
There was a problem hiding this comment.
Suggested change
| equiv = equiv and equivalent(first[i], second[i]) | |
| equiv = equiv and equivalent(f, s) |
Co-Authored-By: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
|
Hello @HasanAhmadQ7! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-08-04 11:18:56 UTC |
Co-Authored-By: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
HasanAhmadQ7
force-pushed
the
fix_open_mfdataset
branch
from
a5eb84b
to
956bf64
Compare
… type Using open_mfdataset on a series of netcdf files having variable attributes with type list will fail with the following exception, when these attributes have different values from one file to another: solves: pydata#3034
Co-Authored-By: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
Co-Authored-By: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
…xarray into fix_open_mfdataset
HasanAhmadQ7
force-pushed
the
fix_open_mfdataset
branch
from
db80ae8
to
d304e56
Compare
|
Thanks @HasanAhmadQ7 ! |
dcherian
added a commit
to yohai/xarray
that referenced
this pull request
Aug 7, 2019
* master: pyupgrade one-off run (pydata#3190) mfdataset, concat now support the 'join' kwarg. (pydata#3102) reduce the size of example dataset in dask docs (pydata#3187) add climpred to related-projects (pydata#3188) bump rasterio to 1.0.24 in doc building environment (pydata#3186) More annotations (pydata#3177) Support for __array_function__ implementers (sparse arrays) [WIP] (pydata#3117) Internal clean-up of isnull() to avoid relying on pandas (pydata#3132) Call darray.compute() in plot() (pydata#3183) BUG: fix + test open_mfdataset fails on variable attributes with list… (pydata#3181)
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Aug 8, 2019
* master: pyupgrade one-off run (pydata#3190) mfdataset, concat now support the 'join' kwarg. (pydata#3102) reduce the size of example dataset in dask docs (pydata#3187) add climpred to related-projects (pydata#3188) bump rasterio to 1.0.24 in doc building environment (pydata#3186) More annotations (pydata#3177) Support for __array_function__ implementers (sparse arrays) [WIP] (pydata#3117) Internal clean-up of isnull() to avoid relying on pandas (pydata#3132) Call darray.compute() in plot() (pydata#3183) BUG: fix + test open_mfdataset fails on variable attributes with list… (pydata#3181)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… type
whats-new.rstfor all changes