Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools-scm and one-liner setup.py #3714

Merged
merged 4 commits into from Jan 22, 2020

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky mentioned this pull request Jan 22, 2020
3 tasks
@crusaderky
Copy link
Contributor Author

I need to retest the RTD CI before merging

@crusaderky
Copy link
Contributor Author

I seem to have no way to test RTD >_<

https://readthedocs.org/projects/crusaderky-xarray/builds/10305870/

@keewis
Copy link
Collaborator

keewis commented Jan 22, 2020

push your branch to the main repository, I'll activate it

Edit: I did it for you: https://readthedocs.org/projects/xray/builds/10305931/

@crusaderky
Copy link
Contributor Author

@keewis done

@keewis
Copy link
Collaborator

keewis commented Jan 22, 2020

hmm... that timed out (see the link above), which also happened before this PR (see #3697). I'll try rebuilding.

@keewis
Copy link
Collaborator

keewis commented Jan 22, 2020

and now it passed, see https://readthedocs.org/projects/xray/builds/10306203/

@crusaderky
Copy link
Contributor Author

Awesome, everything looks in order.
This is now ready for review and merge.

@dcherian dcherian merged commit 27a3929 into pydata:master Jan 22, 2020
@dcherian
Copy link
Contributor

Thanks @crusaderky & @keewis

dcherian added a commit to dcherian/xarray that referenced this pull request Jan 22, 2020
* 'master' of github.com:pydata/xarray:
  setuptools-scm and one-liner setup.py (pydata#3714)
@keewis
Copy link
Collaborator

keewis commented Jan 22, 2020

don't we need to put setuptools (of which pkg_resources is a part of) into install_requires?

@max-sixty
Copy link
Collaborator

Awesome! Thanks @crusaderky & @keewis .

FWIW I don't think we need a MANIFEST.in now; setuptools_scm uses whatever is tracked by source control. But no harm either

@crusaderky crusaderky deleted the setuptools-scm branch January 24, 2020 09:39
@crusaderky
Copy link
Contributor Author

@keewis interesting question. setuptools is technically not part of the Python standard library, but it is part of pip and is always included with the cpython binaries, conda create python=3.6, and pypy. So... I'm not sure?

dcherian added a commit to fujiisoup/xarray that referenced this pull request Jan 25, 2020
* 'master' of github.com:pydata/xarray: (27 commits)
  bump min deps for 0.15 (pydata#3713)
  setuptools-scm and isort tweaks (pydata#3720)
  Allow binned coordinates on 1D plots y-axis. (pydata#3685)
  apply_ufunc: Add meta kwarg + bump dask to 2.2 (pydata#3660)
  setuptools-scm and one-liner setup.py (pydata#3714)
  Feature/align in dot (pydata#3699)
  ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… (pydata#3618)
  One-off isort run (pydata#3705)
  hardcoded xarray.__all__ (pydata#3703)
  Bump mypy to v0.761 (pydata#3704)
  remove DataArray and Dataset constructor deprecations for 0.15  (pydata#3560)
  Tests for variables with units (pydata#3654)
  Add an example notebook using apply_ufunc to vectorize 1D functions (pydata#3629)
  Use encoding['dtype'] over data.dtype when possible within CFMaskCoder.encode (pydata#3652)
  allow passing any iterable to drop when dropping variables (pydata#3693)
  Typo on DataSet/DataArray.to_dict documentation (pydata#3692)
  Fix mypy type checking tests failure in ds.merge (pydata#3690)
  Explicitly convert result of pd.to_datetime to a timezone-naive type (pydata#3688)
  ds.merge(da) bugfix (pydata#3677)
  fix docstring for combine_first: returns a Dataset (pydata#3683)
  ...
@shoyer
Copy link
Member

shoyer commented Jan 27, 2020

This is a lovely clean-up, but unfortunately I think it broke GitHub's "Used by" feature, which no longer appears at the top of this repository: https://twitter.com/shoyer/status/1221676802793295872

It's kind of awkward, but maybe we should add a minimal requirements.txt file for the benefit of GitHub?

dcherian added a commit to dcherian/xarray that referenced this pull request Jan 27, 2020
* master:
  Add support for CFTimeIndex in get_clean_interp_index (pydata#3631)
  sel with categorical index (pydata#3670)
  bump min deps for 0.15 (pydata#3713)
  setuptools-scm and isort tweaks (pydata#3720)
  Allow binned coordinates on 1D plots y-axis. (pydata#3685)
  apply_ufunc: Add meta kwarg + bump dask to 2.2 (pydata#3660)
  setuptools-scm and one-liner setup.py (pydata#3714)
  Feature/align in dot (pydata#3699)
  ENH: enable `H5NetCDFStore` to work with already open h5netcdf.File a… (pydata#3618)
  One-off isort run (pydata#3705)
  hardcoded xarray.__all__ (pydata#3703)
  Bump mypy to v0.761 (pydata#3704)
  remove DataArray and Dataset constructor deprecations for 0.15  (pydata#3560)
  Tests for variables with units (pydata#3654)
  Add an example notebook using apply_ufunc to vectorize 1D functions (pydata#3629)
  Use encoding['dtype'] over data.dtype when possible within CFMaskCoder.encode (pydata#3652)
@crusaderky crusaderky mentioned this pull request Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define a process to test the readthedocs CI before merging into master
5 participants