Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add rioxarray and other external examples #3757

Merged
merged 5 commits into from Mar 5, 2020
Merged

DOC: Add rioxarray and other external examples #3757

merged 5 commits into from Mar 5, 2020

Conversation

snowman2
Copy link
Contributor

@snowman2 snowman2 commented Feb 6, 2020

@dcherian dcherian requested a review from keewis February 24, 2020 19:05
@dcherian dcherian changed the base branch from master to stable February 24, 2020 19:05
@dcherian dcherian changed the base branch from stable to master February 24, 2020 19:06
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except from the rendered IPython output (which is a mess, see below), this looks good to me. We might want to think about adding rioxarray as documentation build dependency and have the output generated when building, with the advantage that should we update / change the DataArray repr, we don't have to remember to update this page.

output

@snowman2
Copy link
Contributor Author

We might want to think about adding rioxarray as documentation build dependency

That brings along with it the fun of GDAL as a dependency.

@dcherian
Copy link
Contributor

dcherian commented Mar 5, 2020

Yeah lets avoid GDAL ;)

The I/O section looks good now

image

@dcherian dcherian changed the title DOC: Add rioxarray link to examples and add example in file IO DOC: Add rioxarray and other external examples Mar 5, 2020
@dcherian
Copy link
Contributor

dcherian commented Mar 5, 2020

Docs build passed. Merging. Thanks @snowman2

@dcherian dcherian merged commit b2f06cb into pydata:master Mar 5, 2020
@snowman2
Copy link
Contributor Author

snowman2 commented Mar 5, 2020

Thanks for the fixes 👍

dcherian added a commit to ej81/xarray that referenced this pull request Mar 14, 2020
…e-size

* upstream/master: (24 commits)
  Fix alignment with join="override" when some dims are unindexed (pydata#3839)
  Fix CFTimeIndex-related errors stemming from updates in pandas (pydata#3764)
  Doctests fixes (pydata#3846)
  add xpublish to related projects (pydata#3850)
  update installation instruction (pydata#3849)
  Pint support for top-level functions (pydata#3611)
  un-xfail tests that append to netCDF files with scipy (pydata#3805)
  remove panel conversion (pydata#3845)
  Add nxarray to related-projects.rst (pydata#3848)
  Implement skipna kwarg in xr.quantile (pydata#3844)
  Allow `where` to receive a callable (pydata#3827)
  update macos image (pydata#3838)
  Label "Installed Versions" item in Issue template (pydata#3832)
  Add note on diff's n differing from pandas (pydata#3822)
  DOC: Add rioxarray and other external examples (pydata#3757)
  Use stable RTD image.
  removed mention that 'dims' are inferred from 'coords'-dict when omit… (pydata#3821)
  Coarsen keep attrs 3376 (pydata#3801)
  Turn on html repr by default (pydata#3812)
  Fix zarr append with groups (pydata#3610)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants