Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfail test_uamiv_format_write #3885

Merged
merged 3 commits into from
Mar 24, 2020
Merged

xfail test_uamiv_format_write #3885

merged 3 commits into from
Mar 24, 2020

Conversation

max-sixty
Copy link
Collaborator

@spencerkclark
Copy link
Member

FYI you'll get an upstream-dev failure due to some ongoing work in cftime: Unidata/cftime#158 (comment). You can temporarily remove it from the build if you'd like, but hopefully it will be resolved soon.

@max-sixty
Copy link
Collaborator Author

Cheers @spencerkclark . Do you know which tests we should xfail? We can do it ex-post if you're not sure.

I think we should really try and keep the build passing, partly as contributor-friendliness, partly as signalling, partly as internalizing the externalities of flaky tests

@spencerkclark
Copy link
Member

Absolutely; it's this one:

xarray/xarray/tests/test_cftime_offsets.py

Lines 1179 to 1184 in c707b33

@pytest.mark.parametrize("freq", ["A", "M", "D"])
def test_dayofyear_after_cftime_range(freq):
pytest.importorskip("cftime", minversion="1.0.2.1")
result = cftime_range("2000-02-01", periods=3, freq=freq).dayofyear
expected = pd.date_range("2000-02-01", periods=3, freq=freq).dayofyear
np.testing.assert_array_equal(result, expected)

Feel free to add an xfail here.

@max-sixty max-sixty merged commit c10c992 into pydata:master Mar 24, 2020
@max-sixty max-sixty deleted the xfail-uamiv branch March 24, 2020 19:24
@spencerkclark spencerkclark mentioned this pull request Mar 28, 2020
Merged
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 28, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into map-blocks-schema
4a355e6 
* upstream/master: (54 commits)
  Limit repr of arrays containing long strings (pydata#3900)
  expose a few zarr backend functions as semi-public api (pydata#3897)
  Use drawstyle instead of linestyle in plot.step. (pydata#3274)
  Implementation of polyfit and polyval (pydata#3733)
  misplaced quote in whatsnew (pydata#3889)
  Rename ordered_dict_intersection -> compat_dict_intersection (pydata#3887)
  Control attrs of result in `merge()`, `concat()`, `combine_by_coords()` and `combine_nested()` (pydata#3877)
  xfail test_uamiv_format_write (pydata#3885)
  Use `fixes` in PR template (pydata#3886)
  Tweaks to "how_to_release" (pydata#3882)
  whatsnew section for 0.16.0
  Release v0.15.1
  whatsnew for 0.15.1 (pydata#3879)
  update panel documentation (pydata#3880)
  reword the whats-new entry for unit support (pydata#3878)
  Raise error when assigning to IndexVariable.values & IndexVariable.data (pydata#3862)
  Re-enable tests xfailed in pydata#3808 and fix new CFTimeIndex failures due to upstream changes (pydata#3874)
  add spacing in the versions section of the issue report (pydata#3876)
  map_blocks: allow user function to add new unindexed dimension. (pydata#3817)
  Delete associated indexes when deleting coordinate variables. (pydata#3840)
  ...
dcherian added a commit to MeraX/xarray that referenced this pull request Mar 29, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into patch-1
068aac7 
* upstream/master: (75 commits)
  Implement idxmax and idxmin functions (pydata#3871)
  Update pre-commit-config.yaml (pydata#3911)
  Revert "Use `fixes` in PR template (pydata#3886)" (pydata#3912)
  update the docstring of diff (pydata#3909)
  Un-xfail test_dayofyear_after_cftime_range (pydata#3907)
  Limit repr of arrays containing long strings (pydata#3900)
  expose a few zarr backend functions as semi-public api (pydata#3897)
  Use drawstyle instead of linestyle in plot.step. (pydata#3274)
  Implementation of polyfit and polyval (pydata#3733)
  misplaced quote in whatsnew (pydata#3889)
  Rename ordered_dict_intersection -> compat_dict_intersection (pydata#3887)
  Control attrs of result in `merge()`, `concat()`, `combine_by_coords()` and `combine_nested()` (pydata#3877)
  xfail test_uamiv_format_write (pydata#3885)
  Use `fixes` in PR template (pydata#3886)
  Tweaks to "how_to_release" (pydata#3882)
  whatsnew section for 0.16.0
  Release v0.15.1
  whatsnew for 0.15.1 (pydata#3879)
  update panel documentation (pydata#3880)
  reword the whats-new entry for unit support (pydata#3878)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@max-sixty @spencerkclark