Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple dims to be passed with min_count #4356

Merged
merged 2 commits into from Aug 20, 2020
Merged

Allow multiple dims to be passed with min_count #4356

merged 2 commits into from Aug 20, 2020

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Aug 19, 2020 •
edited

Test may be insufficient, but here's a first go

mathause
mathause approved these changes Aug 20, 2020
View reviewed changes
Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dcherian
dcherian approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Add a whats-new entry?

@max-sixty max-sixty merged commit 43a2a4b into pydata:master Aug 20, 2020
@max-sixty max-sixty deleted the min-count-nd branch August 20, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

@mathause mathause mathause approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sum: min_count is not available for reduction with more than one dimensions
3 participants
@max-sixty @dcherian @mathause